esm: unflag extensionless ES module JavaScript and Wasm in module scope #49974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoffreyBooth
added
esm
Collaborator
|
Review requested:
|
nodejs-github-bot
added
errors
github-actions
bot
removed
the
request-ci
Collaborator
Contributor
|
Maybe add
baking-for-lts
|
Collaborator
benjamingr
approved these changes
Sep 30, 2023
Collaborator
GeoffreyBooth
added
baking-for-lts
Member
Author
That’s a good idea, I assume I should use that without the |
16 tasks
12 tasks
Member
Author
|
@LiviaMedeiros or someone else, do you want to approve this? Then it can land. |
guybedford
approved these changes
Oct 2, 2023
Contributor
guybedford
left a comment
guybedford
left a comment
There was a problem hiding this comment.
The lookup logic all looks correct to me.
targos
reviewed
Oct 2, 2023
targos
approved these changes
Oct 2, 2023
Member
|
Landed in 9c68320 |
This was referenced Oct 9, 2023
This was referenced Nov 11, 2023
targos
added
backported-to-v18.x
and removed
baking-for-lts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up from #49869, this PR allows extensionless ESM JavaScript and Wasm files within
"type": "module"package scopes to run as entry points or be imported. This can be done as a semver-minor change because currently such files error when they are within amodulescope. (Outside of such a scope, they are interpreted as CommonJS modules unless--experimental-default-type=moduleis passed.)This was discussed in the most recent TSC meeting, nodejs/TSC#1442. At that meeting it was agreed that this change could go out in 21.0.0, but not immediately in 20.x or below. It doesn’t need to be restricted from 20.x indefinitely, but there was a request to hold off on backporting it to 20.x until it had been public in 21.x for a bit. I’ve added labels accordingly.
@nodejs/loaders @nodejs/wasi